CVS log for Amaya/annotlib/ANNOTevent.c

Request diff between arbitrary revisions

Display the annotation title
Irene

Possible uninitialized variable
Irene

Integration of Yusuke Ishii patches
Irene

Missing parameter in callback functions
Irene

Update some French dialogs + documentation
Irene

Amaya now accepts to create <ins> and <del> as block elements
Irene

Typo
Irene

Display the proxy setting information (if it exists) when a server cannot be contacted.
Laurent

Integration of Regis patches
Irene

Integration of Regis Boudin patches.
Irene

When the user has a non-ISO login, annotations and transformations didn't
work.
Irene

Adding string convertions in Annotations code (provided the system gives
a right locale value).
Irene

code cleaning + warning fixes
S. GULLY

Update the copyrigh.
Irene

Unification of shortcuts support (GTK/WX/MacOS)
Irene

renaming CloseWindow to AmayaCloseWindow because CloseWindow allready exist in MSWindow api...
S. GULLY

+ adding CloseWindow menu item for wxWidgets version
+ renaming ClosePage to CloseTab (ctrl x + ctrl t) (wxWidgets)
+ renaming CloseDocument to CloseWindow (all version)

S. GULLY

JK: cleaned the code. Removed all the refs. to the libwww RDF parser
and to the raptor stand-alone parser, as we're compiling with redland
now.

JK: Code cleaning

Remove calls to snprintf.
Irene

Removing _I18N_ within amaya and annotlib directories
Extending the copyright to 2004
Adding needed convertions utf-8 to the default charset.
Irene

This is the Amaya C++ version : ie amaya uses now g++ (c++ version of gcc)

WARNING:
Before compilation do :
    - On debian just install g++ : "apt-get install g++"
    - A cvs update into libwww directory because there is a expat header to update.
    - "rm -rf *"
    - "../configure [options...]"

S. GULLY

Adding the Referer field in some HTTP/GET requests.
Irene

JK: The new raptor included in redland requires a specific init/finish
calls. When using redland, those calls are made directly thru the
redland's init/finish higher level calls.

JK: DocStatusUpdate was called with a wrong value

JK: The disk button wasn't always being reset after doing a save of
an annotation

JK: Fixed two memory leaks reported by insure

JK: Protection against empty servers in the annotlist server list

JK: Make sure both the body and the annotation metadata are not in the
cache when saving a new version.

JK: Separating the initialization of bookmarks from annotations

JK: Intermediate changes that allow to compile with redland/raptor
or with the standalone libraptor (as included in Amaya). Will become
redland only once DB releases it!

JK: removed gcc warning

JK: Make the using of update POST optional through an environment
variable, in case some servers don't handle PUT yet (and to keep
users from ditching Amaya!)

JK: Conformance to the new Annotea protocol draft: do a PUT when
updating an annotation. This required making changes so that we can
retrieve the body of a PUT reply.

JK: if a document had some annotations, they were not shown after doing
a synchronize.

JK: Memory was being freed too early.

JK: Fixing a sigsev bug related to my last patch.

JK: Fixes to many bugs related to Annots on Annots and replies... fixes
confusions with the annot_url and body_url for some operations.

JK: A small bug fix for the current BIG bug.
Doesn't solve yet all the problems

JK: fixing the update bug

JK: When the user deletes an annotation, put a selection on the text that
was annotated.

Bug fixes:
- memory leaks in the fonts handler
- internationalization of annotlib
Irene

Rename Iso functions + bug fix in XHTML doctype.
Irene

Make some progress with the support of Japanese characters + some bug fixes
- The internationalization of URIs didn't work correctly
- The GTK version of print crashed.
Irene

JK: If the local annot autoload was active, Amaya crashed when closing a
document before it was fully downloaded.

JK: Fix an I18N bug wrt the author's name

JK: fixing the thread refresh bug on windows

JK: Fixing compilation bugs when compiling without ANNOT_ON_ANNOT
(for Martin)

JK: Xmas present commit for Ralph:
Update the annotation icons when changing the type (you must save the annotation
to make the change effective).

JK: Deleting a non saved reply didn't update the thread items or
delete the memory the item was using.

Fixing warning messages.
VQ.

JK: fixed the link on the thread items. After my last commit, they were
poingint to the source document of the reply rather than to the reply
itself.

JK: Fixing a memory bug detected by insure

JK: Posting an annotation that had local replies or annotations attached to it
didn't update the local metadata to point to the new URL.
The reverse link from the metadata "source_doc" didn't work on annots on
annots.

JK: Delete of remote annotations that were not replies caused a SIGSEV
(missing condition).

JK: Merge remote + local replies + resort.

JK: Fix some broken cases with annotation delete and when creating
replies on annotations to reply items.

JK: oufff! Fixed a compilation error when not using ANNOT_ON_ANNOT

JK: Be scared! A commit dans l'etat so that I don't lose my job if something
happens to my laptop.
.
Adaption of JamieZ's thread message sorting algorithm.
Date sort of threads (code written for the old sort algorithm, but not yet
adapted to the new algorithm).
Some changes for annotations/thread deletes, updates, posts.
Some bugs remain, but I'm working on them.
Compiles without problems with the ANNOT_ON_ANNOT option. No time to verify
if there's a compiler problem without this flag. Feel free to fix and
commit those changes if that situation happens (or even rollback).

Cosmetic changes + compiling error in ANNOTevent.c
Irene

jK: compiler warning

JK: Annotation replies bug fixes, enhancements.
Things missing: sort the threads by date (sorted by reply to done)
Update the local annotations annotates and replies-to info after a post.
UI: show annotations in same window when browsing.

When an annotation view was closed without saving the annotation the
local index was being updated.  When an annotation was deleted before
saving it, a bogus local annotation was added to the index.

JK: Fixing compiler warnings. Adding UTF8 support for document title +
author metadata fields.

JK: Hopefully, fixed the thread and annot/annot confusion bugs.
Some minor code cleaning.

JK: Several annotation/annotation and thread bug fixes (mostly for local
annotations).

JK: Make single click on the annot icon select the annotation again.

JK: A patch for uniformizing the use of file:// regardless of the platform.
This should fix up bugs we had when we wrongly added the file: prefix without
converting the rest of the URL under Windows platform. The patch should be
backwards compatible with existing annotations.
New URLs under Windows will now read: file:///drive:path.

JK: The last bug fix had the problem that it wasn't possible to double
click on a thread-item. Went back and applied a different patch.

JK: Annotation threads. Made reload of an annotation doc + threads work.
Now showing the title of annotation + author's name + last modif. date
in each thread item. Make new thread items be added at the end of the
thread, rather than as the first child (still needs work to sort the
threads). Make selection work on the desc item, rather than on the
thread item. Some bug fixes.

JK: Annot threads: removed the pencil icon for annotations. Selection
now works from the thread items. Changed the thread view to say "Replies",
some other fixes.

JK: Clicking in the thread item will open a new window now.

JK: Select the active thread item in the thread view (in progress)

JK: update the thread information if the user changes the title
of a reply.

JK: Annot threads. Now showing the title of the annotations in the thread.
Reduced the thread indentation. Some bug fixes too.

JK: Allow to add a reply on any window, not just doc window 2.

JK: Saved threads can now be reloaded.

JK: Annotations/annotations.
Show the title of the annotation that's being annotated or its URL if
not found.
Automatically give a title to an annotation (Annotation of... Reply to...)
when creating a new annotation. User can modify it later.

JK: title of annotations

JK: Thread changes... now locally saving and downloading annotations
(in progress).

Unicode stuff + code clean up
Irene

JK: Early commit for Ralph, Marja... first threads created with Amaya

JK: Code cleaning (un stdcing)

JK: Enabling annotations on annotations

JK: protecting thru ifdefs my threading work.
Add in Options -DANNOT_ON_ANNOT to activate.

JK: Syncing the annotlib with Vincent's last commit

Removing the macro TEXT ()
Irene

JK: changed a static text message to TtaGetMessage

JK: Fixing compiler warnings
Annotlib: code cleaning (rewrite of all the include statements + use of
annotlib.h)
Changed the Amaya version and date.

JK: Move annotations: Restrict this operation to the same document.
XPointer, memorize the full XPointer.

JK: Annotations of Table, THead, TBody, Tfoot elements.
New function for memorizing an XPointer.
New functions for re-assigning annotations to the value of a memorized
XPointer or to the current selection (work on progress).

JK: When making a new annotation, we first try to compute the XPointer.
If this operation fails, we don't open the annotation window anymore.
Previously, we always opened the annotation window.

JK: New annotation config options for switching off auto-load

JK: Show error messages from the server in the status bar

JK: Removed all the compiler warnings that appear when compiling with
-Wall and -O2.
The remote raise source_doc and delete callbacks weren't checking the
return status code.

branched for ANNOTevent.c only;
RRS: if the post server is not already on the query server list, possibly
prefixed with hypen (i.e. disabled) then add it to the list automatically
with a hyphen prefix so the user can easily enable it for queries.

JK: If a server names begin with a "-" char, ignore it when downloading
annotations (saving will too, but it's ignored later on)

JK: Rolling out of Ralph's changes (tagged them as ANNOTPOST)

If the user forgets to include the annotation post server in the list of query
servers, include it for her at the end of the list.  Feature requested by Marja.
RRS

JK: Spent 25 minutes adding a new accesibility function and 30s outcommenting
it, as I'm not sure if it's useful or not.

JK: Rewrote the annot filters functionality so that they are displayed
automatically. New three state indicator "visible, hidden, partially visible".
Some code cleaning tasks need to be done yet (re AnnotDelete).

JK: missing file

Merge exp_AnnotAuthUser branch into main branch.  This will display three
additional fields in the annotation metadata if the server supplies them,
else nothing will display.
RRS

Merge changes from rev 1.79 to rev 1.81

JK: fixed a typo and added some missing comments

JK: Bug fix: we were trying to free resources allocated to an annotation
document for all the documents (reported by Vincent).

Experimental support for displaying authenticated user information
from an Annotea service.  This adds three fields to the annotation
metadata and changes some interfaces in ANNOTschema.  This is
checked-in to a branch tagged exp_AnnotAuthUser so that Jose can
look it over and decide whether to merge it.
RRS

Capture the namespace name of the annotation schema from annot.schemas.
Relocate all other hard-coded namespace names to annotlib.h to make
future maintenance easier.

JK: Moved the initialization of the default registry values to MENUconf.c
Initialization and protection against an empty user name.

JK: Dealing with orphan annotations.
For delete annotation, memorizing the last selected annotation by document
(rather than globally).
Added a call to StopTransfer when freeing the resources of an annotation.

JK: New function: AnnotateDocument

Mark orphanned annotations (those whose context XPointer no longer
selects an existing element) and bodyless annotations and write
a log of these in APP_TMPDIR.  This code is on a branch tagged
exp_AnnotErrLog for purposes of concurrent development.
RRS

When a local annot was posted as a shared annot, the local body file was
deleted but the index was not updated immediately.  If the user reloads
the page now there would be a body-less annotation left.  Update the
local index as soon as the post succeeds.  Also, remove old/unused function.
RRS

Don't segv when trying to delete a remote annotation when the
service didn't return a body URI.  Really fix local delete this
time [which I broke :-( in rev 1.70]
RRS

Bugfix: if annotation configuration was changed while an annotation
was open the types list used stale resource pointers.  Fix this by
splitting out ANNOT_FreeConf (a new function) from ANNOT_Quit.
RRS

JK: Remove the fallback test for HTTP DELETE

JK: Local delete wasn't working anymore

Reload the annotation schemas completely after changing the
annotation configuration.
RRS

Use {APP_DIR,THOTDIR/config}/annot.schemas to configure the annotation
schemas instead of ANNOT_SCHEMA from the registry.  Fix a bug in DELETE;
we were sending the wrong URI.  Request application/xml instead of
application/rdf when querying and reading annotations.  Drop the old
"positive comment", "flame", and "(comment)" fallback types.  Establish
basic infrastructure for enabling locally specific annotation subtypes.
RRS

JK: Using HTTP DELETE for annotations delete

Free all permanently allocated RDF resources before exiting.

JK: Bug fix... when posting a local document, the document's URL wasn't
being updated anymore (typo with missing parentheses)
Some changes for some delete tests that didn't work.

JK: Bug fix: the schema types were being erased when deleting the filters.
Enhancement: if you create an annotation and then quit without saving it,
the annotation is deleted.
In progress: the delete annotation doesn't clear yet all the metadata when
the annotation document is open. It's a problem of calling TtaCloseDocument
rather than CloseDocument.

JK: Handling of the stop button (in progress)
Better memorization of the last selected annotation, for the delete
button (in progress)
This is an early commit so that I can send a bug report.

JK: Cleaned the post_callback cleanup functions, which were not
always making the correct assumptions.
When posting an annotation that hadn't been saved, the body was being
generated in an incorrect way. This had bad side-effects while computing the
content-length and house cleaning.
Adding some protection so that asynchronous annotations don't arrive after
the source document has disappeared.

JK: Bug fix, the by type annotation filter wasn't working anymore.

JK: When creating a new annotation, reselect the annotated text.

JK: Suppresed a dangerous loop while freeing annotation resources.

JK: the annotation schema wasn't being downloaded  when creating a new
annotation.. a patch to a patch to a hack :-/

JK: Changed the default so that annotations are not downloaded automatically

JK: Protected two debug messages RRS introduced by using RRS_DEBUG,
rather than the general DEBUG macro.

Turn off 'doc modified' after the annotation has been successfully posted.

Return the annotation type properly from the selection dialogue.
Delay updating the local annotation index until after the annot file
is written so all the properties have their final value -- including
type.  Add some fencepost tests to FindRDFResource and FindRDFStatement
to protect from callers who pass invalid arguments.

Add ANNOT_SCHEMA resource to permit identifying the location of the
annotation schema file, including a local file cached copy.  Create
such a locally cached copy in the config directory.

JK: Annot Local filter menu for windows

JK: first try at a Windows AnnotTypes menu

JK: The annotation is now placed as the first child of MathML and SVG
fragments.
Changes so that we can annotate a single MathML/SVG documents.

JK: File cleaning: removed two schemas we were not using.
Bug fixes: List_delAll wasn't freeing the memory associated to objects.
The func. API now includes an argument for specifying the function that should
free an object.

JK: If the user clicked on the reverse link from the annotation to the
soure doc, and if the annotation was stored locally, the annotated text
wasn't being selected.
Code simplification: moved all the code in the diverse functions that
were concatenating file:// to a URL to ANNOT_MakeFileURL.

JK: Bug fixes/enhancements to the remote protocols
Using now a specific anotation element (XLink, declared in XLink.S),
instead of piggy-backing on an HREF one (with the IsAnnotation attribute).
This allows to insert annotations anywhere on a document, without worrying
about the DTD and other goodies.

JK: Added the POST modified protocol (not yet tested against the server)

JK: Making a new annotation without loading the local ones would erase
the previous local annotations.
Fixes so that the filters are updated after a delete

Use 'Comment' rather than (undefined) 'comment' for default annotation type.
Fix bug when updating local annotation index that caused "#" to be replicated
in annotation type.
Fix display of annotation type that is not from the default schema.
Preliminary support for better selection of annotation type.

First (basic) level of support for processing RDF schemas.
This parses the entire schema but only uses it to extract
the human-readable text for the annotation type.

JK: When freeing a modified annotation document, insist that the user
closes/saves it. Small bug fix in the related code.

JK: new functions for freeing all the annotation resources related to a
document, when this document is freed.

JK: Update the local master index only for local annotations.
Code cleaning: removed all the non-used legacy functions.

JK: first try at the annot delete server protocol

JK: preparing the work for the remote delete.
Bug fix: the annot.index wasn't being updated.

plug a memory leak and repair a memory corruption when saving a local annotation

JK: Delete of local annotations

JK: Fixed the bug introduced by the reverse linking mechanism and the
changes in the handling of "/".
Some initial code for deleting annotations.

JK: A simple click on the pencil icon selects the annotated text,
a double click opens the annotation window.
Code cleanup.

JK: Code cleaning.
If the user clicks on the source doc link, the annotated text is highlighted.

JK: code changes for being able to post/save a remote file

JK: First try at Save/Post.
Needed: decide what to do for the next save after the first post.
Bugs: after the first post, we need to create a local temporary file to
continue saving from it.
Bug fix: I hadn't initialized the new initial_url variable.

JK: Preparing the work for using the Save/Post buttons in the new way.
These changes are for changing the reverse link in the source document
when doing a POST of a local annotation. We also remove the local annotation.
To be done:
Clean the annotation index and the metadata related to a posted annotation.

Make remote annotation servers work in Windows

JK: diverse bug fixes concerning the confusion between annot_url and
body_url.

JK and RRS : Safeguard commit before the demo
- New Timinificator easter egg
- Added an active reverse link to the document (a problem to jump to the
- name anchor seems to remain)
- Added a menu for changing the annotation types
- temporary hack to add a default type if it's missing
- we're now able to retrieve the body of a remote annotation.

JK: now using dynamic memory for the custom query string

JK: Simplified the custom query menu and added a free entry algae query
box. We still need to choose the default text of this query.

JK: more work on the local filter. Added a * to say that an entry is
shown/hidden. Showing only one entry item even if it exists many times.
More work to be done yet!

JK: Added a toggle for showing/hiding all the annotations in a document.
Working on the general show/hide annotation menu (temporarily branched
on the CustomQuery menu).

RRS: fix parseType value to conform to RDF.  Maintain file:// in the
annot source_url consistently when annotating local resources.

JK: connected the Annotation configuration menu.
Added code to be able to consult n annotation servers.
Some bugs and memory leak changes.

RRS: complete a round-trip with the annotation database.
This requires the fixed annotate CGI; rev 1.24
Add the new annotation to the list when POSTing after the first one.
Update the annot struct from the server's reply after POST.
Introduce LINK_RemoveLinkFromSource (unfinished; need to construct annotName)
Introduce List_rem, Annot_free

The magic "CGI/annotate" URI should be part of the annotation server name;
e.g. http://bootsy.w3.org:8000/CGI/annotate - make it so.

Fix 1.17 and 1.18 the right way this time; have to take care of ASYNC handling

Don't overwrite the .rc setting for ANNOT_SERVER.
Don't free memory more than once if the POST fails.
Give a debugging message if the POST fails.

Avoid using freed memory when an annotation fails to load.

JK: working on the last steps... reading an annotation from the server.

JK: Support for the last modified date, progress in reading from the RDF
dbase.. Next step, following a link to something stored there.

Ralph Swick: Big code cleanup, various enhancements, some Jose's bugs left

JK: code cleanup, preparing the query to the RDF server.

JK: suporting RDF on the locally stored annotations

JK: integrating a tree-less  annotation parser built on top of expat.
It compiles, but annotations are broken for the moment.
Changing the local annotation format to RDF too.

JK: fixed warnings. Added code to remove the DocumentModified status
after having saved a document.

JK: fixed a typo in the generated rdf (rdf.tmp). Enhanced the standalone
parser to parse the reply to the RDF dbase queries.

JK: First try at having a  Annotation/RDF parser based on expat.
rdfparser.c first builds a DOM tree of an RDF file (which is in XML),
then browses thru it (CDATA inclusion and browsing isn't ready yet). It uses
the thotlib and is compiled at the same time as annotlib.
rdfparsernotree.c is a quick try at parsing the RDF file without building
a DOM tree (it works, but the code is ugly).
XmlStr.S gives a generic schema for XML documents and is used to build the
DOM tree. XmlStrT outputs an XML file from a DOM tree.
N.B. The DOM tree is in fact a thotlib DOM-like tree.

typo; make the annotation valid XML

JK: Changes for taking into account the unicodification of Amaya
(work under progress).
Now using NormalizeFile to deal with the file: URLs.

JK: small update so that Ralph can compile

JK: fixed the annotation Makefile dependencies
    new options and changes from the MIT annot meeting.
    Moved all the annot options to a specific menu.

JK: integrating the new annotation schemas

Some warning fixes, detected while compiling under Windows

JK: moved the annot stuff from the amaya directory. Made it compile as
libannot.a